Skip to content

Specify yarn classic as PM for js-sdk wrapper #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3chguy merged 1 commit into from
Feb 17, 2026
+2 −1
Merged

Specify yarn classic as PM for js-sdk wrapper #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/api/js/js-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@
"buffer": "^6.0.3",
"matrix-js-sdk": "40.0.0",
"vite": "^5.4.21"
}
},
"packageManager": "yarn@1.22.22"
Copy link
Member

@richvdh richvdh Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to pin it to a specific version?

Copy link
Member Author

@t3chguy t3chguy Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn classic 1.x behaves extremely differently from yarn berry 4.x so I recommend doing so even if it is not necessary. The yarn.lock is generated by yarn classic, so using yarn berry would make an incompatible lockfile. https://github.com/matrix-org/complement-crypto/blob/main/internal/api/js/js-sdk/yarn.lock#L2

}
Loading