Skip to content

Conversation

@matomoto
Copy link

Add a new function "unrequireConsent".

Description:

When _paq.push(['requireConsent']) is called, it is possible to revoke this with _paq.push(['unrequireConsent']). So no _paq.push(['setConsentGiven']); is required. This will cause all tracking requests from this page view to be sent.

Review

Add a new function "unrequireConsent".
@matomoto
Copy link
Author

More information: One of the current problem is that setConsentGiven ignore disableBrowserFeatureDetection and disableCookies. That's touched the EU directive. Another problem is, that the matomo consent peripherie is non-flexible. It is only styled for one case: EU or not EU. By a worldwide website it is difficult to impossible to code a solution for all. With unrequireConsent it is possible to set basically a requireConsent and two buttons for EU (setConsentGiven) and outside EU (unrequireConsent) visitors. All problems solved.

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 11, 2025
@matomoto
Copy link
Author

matomoto commented Jul 13, 2025

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

A typically idiocracy on Github. Users don't have the rights for this.

Repository action Read Triage Write Maintain Admin
Apply/dismiss labels
Create, edit, delete labels
Close, reopen, and assign all issues and pull requests

https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization

add initialize unrequireConsent
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 14, 2025
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale for long The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Sep 9, 2025
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale for long The label used by the Close Stale Issues action

Development

Successfully merging this pull request may close these issues.

1 participant