Switch to proxy URL to handle API requests to demo, #PG-5029#876
Open
Switch to proxy URL to handle API requests to demo, #PG-5029#876
Conversation
| window.onload = function () { | ||
| let pluginSpec = {{ pluginSpecJson|raw }}; | ||
| let pluginSpecJson = {{ pluginSpecJson|raw }}; | ||
| let proxyBaseUrl = window.location.origin + '/demo-proxy'; |
Contributor
There was a problem hiding this comment.
Suggested change
| let proxyBaseUrl = window.location.origin + '/demo-proxy'; | |
| let proxyBaseUrl = '/demo-proxy'; |
|
|
||
| $proxiedResponse = DemoProxy::get($targetUrl, $request->getHeaderLine('Authorization')); | ||
|
|
||
| $response->getBody()->write($proxiedResponse['body']); |
Contributor
There was a problem hiding this comment.
we should add a try/catch here
| }); | ||
|
|
||
| $app->get('/demo-proxy/{path:.*}', function (Request $request, Response $response, $args) { | ||
| $path = ltrim($args['path'] ?? '', '/'); |
Contributor
There was a problem hiding this comment.
main concern is that it now becomes a proxy to query demo.matomo.cloud without any CORS error
We can add a check that requestURL path should be index.php and Module should be API along with CSRF token.
Contributor
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
Is this correct ?
AltamashShaikh
requested changes
Mar 31, 2026
Contributor
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
left few comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Checklist
Review