Skip to content

build: use pyproject.toml #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jolars wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: use pyproject.toml #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a927b0
build: use pyproject.toml
jolars Apr 29, 2025
e0ff498
fixup! build: use pyproject.toml
jolars Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
[build-system]
requires = ["setuptools>=42", "wheel"]
build-backend = "setuptools.build_meta"

[project]
name = "libsvmdata"
dynamic = ["version"]
Copy link
Owner

@mathurinm mathurinm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to specify where it is defined, like we do here : https://github.com/scikit-learn-contrib/skglm/blob/main/pyproject.toml#L36

Copy link
Owner

@mathurinm mathurinm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, so far it's thinking this is version 0.0.0:

      Successfully uninstalled libsvmdata-0.5.dev0
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
celer 0.7.3.dev0 requires libsvmdata>=0.3, but you have libsvmdata 0.0.0 which is incompatible.
Successfully installed libsvmdata-0.0.0

Copy link
Collaborator Author

@jolars jolars Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, thanks! Fixed it now.

description = "Fetcher for datasets"
authors = [{ name = "Mathurin Massias", email = "mathurin.massias@gmail.com" }]
maintainers = [
{ name = "Mathurin Massias", email = "mathurin.massias@gmail.com" },
]
readme = "README.rst"
license = { text = "BSD (3-clause)" }
requires-python = ">=3.6"
dependencies = ["download", "numpy>=1.12", "scikit-learn", "scipy"]

[project.urls]
"Download" = "https://github.com/mathurinm/libsvmdata.git"

[tool.setuptools]
packages = ["libsvmdata"]
dynamic = {version = {attr = "libsvmdata.__version__"}}

[tool.flake8]
exclude = "__init__.py"
4 changes: 0 additions & 4 deletions requirements.txt
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions setup.cfg
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions setup.py
View file
Open in desktop

This file was deleted.

Loading