Add support for 2.8" round TURZX USB display (PID 0x0028)#995
Open
OctaNebula wants to merge 1 commit intomathoudebine:mainfrom
Open
Add support for 2.8" round TURZX USB display (PID 0x0028)#995OctaNebula wants to merge 1 commit intomathoudebine:mainfrom
OctaNebula wants to merge 1 commit intomathoudebine:mainfrom
Conversation
Register the 2.8" round panel (480x480, USB Product ID 0x0028) with the existing TURZX USB comm class. This is the new-generation USB variant of the 2.8" screen, distinct from the older UART-based 2.1"/2.8" models. Changes: - Add PID 0x0028 to the PRODUCT_ID table in lcd_comm_turing_usb.py - Add a new size option in configure.py for the GUI dropdown - Fix a latent bug in load_config_values where .replace() on size strings could produce corrupted values like '2.1" / 2.1" / 2.8"' due to substring matching — switched to equality checks instead - Update README supported sizes list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the 2.8" round panel (480x480, USB Product ID 0x0028) with the existing TURZX USB comm class. This is the new-generation USB variant of the 2.8" screen, distinct from the older UART-based 2.1"/2.8" models.
Changes: