Preload en locale in component definitions#1494
Open
dpvc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds files to the
components/mjssubdirectories in order to pre-load theenlocale definitions when the components are webpacked (or loaded into a node application). This required the addition of a#tspseudo-path in order to be able to access the definitions from thetsdirectory (since they might not have been moved to themjsorbundledirectories yet).This is done through the use of separate
en.jsfiles for each component so that it would be possible to use the webpack configuration to replace them easily with files for another locale, if a version with a different built-in default wanted to be created.An alternative would be to move these to the
ts/**/__locales__directories and have theComponent.tsfiles load them directly. Then even node applications with direct calls to the modules would have the defaultenlocalization automatically, and there would not be a need for the warning message ifLocale.setLocale()wasn't called first. But then node applications that change the default locale will end up loading bothenand the new one, whereas with the files where they are now, that would not be the case for direct module loading. I'm not sure which is the better approach.