Skip to content

Fix handling of font-* css that aren't being specially handled, like font-size-adjust#1431

Open
dpvc wants to merge 1 commit intodevelopfrom
fix/styles
Open

Fix handling of font-* css that aren't being specially handled, like font-size-adjust#1431
dpvc wants to merge 1 commit intodevelopfrom
fix/styles

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Feb 14, 2026

This PR fixes a problem with the ts/util/Styles.ts handling of some CSS where the root property is defined by the sub-process isn't, such as font-size-adjust. Without this PR, processing that style (say in the LiteDOM) would cause an error. A new test is added to check or this.

I found this by running all the examples from the documentation on the 4.1.1 candidate.

@dpvc dpvc requested a review from zorkow February 14, 2026 22:48
@dpvc dpvc added this to the v4.1.1 milestone Feb 14, 2026
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.51%. Comparing base (40226d1) to head (b182f06).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1431     +/-   ##
==========================================
  Coverage    86.51%   86.51%             
==========================================
  Files          340      340             
  Lines        86030    86031      +1     
  Branches      4832     3191   -1641     
==========================================
+ Hits         74429    74430      +1     
- Misses       11577    11601     +24     
+ Partials        24        0     -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant