Add isEmpty test (deep tree check) to MmlNode and use it to test for empty mathop.#1428
Merged
Add isEmpty test (deep tree check) to MmlNode and use it to test for empty mathop.#1428
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1428 +/- ##
========================================
Coverage 86.51% 86.51%
========================================
Files 340 340
Lines 86002 86032 +30
Branches 3186 3190 +4
========================================
+ Hits 74406 74432 +26
- Misses 11596 11600 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
approved these changes
Feb 5, 2026
Member
zorkow
left a comment
There was a problem hiding this comment.
lgtm.
There is one more occurrence in MathtoolsUtil.ts that you could replace.
Member
Author
I had looked at that one, but didn't think it was necessary, but I've changed it, as I don't think it should hurt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
isEmtpygetter to theMmlNodeclass that does a deep tree test to see if an element contains only empty elements and that token nodes only empty text nodes as children. This is used in the test for empty\mathopelements so that it catches\mathop{\mathrm{}}as empty, the original case the Peter reported.It also adds an additional test to check for that situation.