Fix problem with fat libraries on iOS due to duplicated symbols.#54
Open
michele-comitini wants to merge 1 commit intomatham:masterfrom
Open
Fix problem with fat libraries on iOS due to duplicated symbols.#54michele-comitini wants to merge 1 commit intomatham:masterfrom
michele-comitini wants to merge 1 commit intomatham:masterfrom
Conversation
Owner
|
Thanks for the fix, but this seems to break on windows (and possibly other compilers that are not gcc). |
Author
|
It should work on clang and gcc.
In any case you wouldn''t want those symbols exposed to the world from
the resulting .so.
I am not on Windows but redefinition or ifdef macros could fix compiling.
Il giorno lun 19 nov 2018, 01:27 matham <notifications@github.com> ha
scritto:
Thanks for the fix, but this seems to break on windows (and possibly other
compilers that are not gcc).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABL7XCSFYO42xIJj3cijDhc_CZ5EDgKxks5uwfsHgaJpZM4YoLEV>
.
Il 19 nov 2018 01:27, "matham" <notifications@github.com> ha scritto:
Thanks for the fix, but this seems to break on windows (and possibly other
compilers that are not gcc).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABL7XCSFYO42xIJj3cijDhc_CZ5EDgKxks5uwfsHgaJpZM4YoLEV>
.
|
Contributor
|
Please rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.