Generalize some results in monalg to nmodType and semiRingType#83
Merged
Generalize some results in monalg to nmodType and semiRingType#83
nmodType and semiRingType#83Conversation
a61a008 to
434bd96
Compare
250c3b6 to
3973f21
Compare
3973f21 to
f184b73
Compare
7bec33e to
cde5b11
Compare
cde5b11 to
4efc3de
Compare
3 tasks
Member
Author
|
I think that instances on the evaluation function ( |
cdbfb3a to
6bedd18
Compare
6bedd18 to
4f530a1
Compare
Member
Author
|
Done. Perhaps the generalization of mmap needs more discussion and should be a separate PR. |
4f530a1 to
96b86c5
Compare
96b86c5 to
50f73a9
Compare
50f73a9 to
53f68a7
Compare
Member
Author
See #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some further generalizations require us to generalize some module and morphism structures on the MathComp side, namely, math-comp/math-comp#1125.
CC: @hivert @amahboubi