Skip to content

rename Tvs to ConvexTvs#1912

Merged
affeldt-aist merged 3 commits intomath-comp:masterfrom
mkerjean:convextvs
Mar 20, 2026
Merged

rename Tvs to ConvexTvs#1912
affeldt-aist merged 3 commits intomath-comp:masterfrom
mkerjean:convextvs

Conversation

@mkerjean
Copy link
Collaborator

@mkerjean mkerjean commented Mar 20, 2026

Motivation for this change

Rename the Tvs class of HB to ConvexTvs, as it describes the structure of locally convex topological vector spaces.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longer renaming just makes things more precise. I think that convexTvsType (rather than convextvsType) is more in line with the other namings so far though.

@affeldt-aist
Copy link
Member

Don't mind the read CI: this is because of a Rocqnavi time out and ssprove that needs to be fixed.

@mkerjean
Copy link
Collaborator Author

Longer renaming just makes things more precise. I think that convexTvsType (rather than convextvsType) is more in line with the other namings so far though.

This has been addressed, as well as the .in the header.

Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
@affeldt-aist affeldt-aist merged commit 92fd159 into math-comp:master Mar 20, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants