feat(slider): updated slider to adhere material design specification#5730
Open
zZHorizonZz wants to merge 8 commits intomaterial-components:mainfrom
Open
feat(slider): updated slider to adhere material design specification#5730zZHorizonZz wants to merge 8 commits intomaterial-components:mainfrom
zZHorizonZz wants to merge 8 commits intomaterial-components:mainfrom
Conversation
- Removed unnecessary image and description for button types - Adjusted margin for slider labels - Updated title and aria-label for slider types
zZHorizonZz
changed the title
Remove the unused import of the 'elevation' module and the corresponding element from the slider component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the slider component to the newest version of the Material Design specification.
There are a couple of things that need to be tested, discussed, and improved:
Closes #5466