[TimePicker] Inherit M3 timepicker button style from M3 button style#5026
Open
pubiqq wants to merge 1 commit intomaterial-components:masterfrom
Open
[TimePicker] Inherit M3 timepicker button style from M3 button style#5026pubiqq wants to merge 1 commit intomaterial-components:masterfrom
pubiqq wants to merge 1 commit intomaterial-components:masterfrom
Conversation
pubiqq
force-pushed
the
timepicker/color-container-fix
branch
from
035f48a to
deafdf5
Compare
drchen
reviewed
Mar 18, 2026
| <item name="clockNumberTextColor">@color/material_timepicker_clock_text_color</item> | ||
| </style> | ||
|
|
||
| <style name="Widget.Material3.MaterialTimePicker.Button" parent="Widget.MaterialComponents.TimePicker.Button"> |
Contributor
There was a problem hiding this comment.
Not sure if this is intended and what's the reason behind this. I'll let someone else to check.
Contributor
|
Dan can you take a look and check why we made the inheritance like this at the beginning? |
Contributor
|
@drchen it looks like you created this style so you may be able to remember better than me 😄 But we either have to choose between:
Right? #2 seems like it would be less duplication / easier to maintain? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes #5025