Add Diluted EPS(Earnings-Per-Share)#801
Add Diluted EPS(Earnings-Per-Share)#801Raptorly1 wants to merge 2 commits intomassive-com:masterfrom
Conversation
|
Hey @Raptorly1, thanks for the PR. I ended up putting together a much large fix that aligns with how we use the other APIs. I'm going to close this PR but this is fixed now via #817 and is in the latest release https://github.com/polygon-io/client-python/releases/tag/v1.14.3. You should be able to just run Here's an example for fetching diluted_earnings_per_share and net_income_loss: Here's the output: |
|
Thank you @justinpolygon . Is there anything like Slack or a roadmap for Polygon so I can see if a fix is already being worked on? |
|
Hey @Raptorly1, we have a public roadmap here and you can also ask for things you're interested in too. https://polygon.io/product-roadmap Cheers, |
|
Good to know! Thanks! |
Fixes #792
This pull request includes changes to the
polygon/rest/models/financials.pyfile, primarily focusing on the addition ofDilutedEarningsPerShareand the inclusion of this in theIncomeStatementclass. Additionally, there are corresponding updates to the test filetest_rest/test_financials.py.New Class Addition:
DilutedEarningsPerShareto represent diluted earnings per share data for an income statement. This class includes the standard attributes I saw:formula,label,order,unit,value, andxpath, along with afrom_dictmethod.Updates to Existing Classes:
IncomeStatementclass to include an optionaldiluted_earnings_per_shareattribute.from_dictmethod of theIncomeStatementclass to handle the newdiluted_earnings_per_shareattribute.Test Updates:
DilutedEarningsPerShareto the import statements in thetest_rest/test_financials.pyfile.test_list_stock_financialsmethod to test the newdiluted_earnings_per_shareattribute in theIncomeStatementclass.