fix: callback error handling and update coverage status #891
+547
−440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move key validation inside doSign/doVerify so errors pass to callbacks - Fix Ed25519 test to use null algorithm (internal hashing) - Add callback error handling tests - Mark timingSafeEqual as implemented in coverage docs
Contributor
🤖 End-to-End Test Results - AndroidStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Contributor
🤖 End-to-End Test Results - iOSStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues found during code review and updates coverage documentation.
Bug Fixes
Callback error handling in sign/verify - Moved key validation inside
doSign()anddoVerify()so errors are properly passed to callbacks instead of being thrown synchronously (matching Node.js behavior)Ed25519 test algorithm - Fixed test to use
nullalgorithm instead of'SHA512'since Ed25519 uses internal hashingNew Tests
sign()andverify()functionsCoverage Updates
timingSafeEqualas implemented in:docs/data/coverage.ts.docs/implementation-coverage.md