Add Locate Features project type#86
Open
frozenhelium wants to merge 2 commits into
Open
Conversation
frozenhelium
force-pushed
the
project/locate-features
branch
4 times, most recently
from
61dee86 to
6cd05da
Compare
frozenhelium
force-pushed
the
project/locate-features
branch
from
6cd05da to
0c18156
Compare
frozenhelium
force-pushed
the
project/locate-features
branch
from
7c07cc0 to
473b7ef
Compare
frozenhelium
changed the title
ofr1tz
reviewed
May 26, 2026
| taskY: y, | ||
| taskZ: Number(project.zoomLevel), | ||
| taskId: `${project.zoomLevel}-${x}-${y}`, | ||
| taskId_real: `${project.zoomLevel}-${x}-${y}`, |
Collaborator
There was a problem hiding this comment.
What is taskId_real used for? It contains the same value as taskId, is that intentional?
| const optionsTemp = this.project?.customOptions ?? this.project?.answerLabels; | ||
| const options = optionsTemp | ||
| ? [...optionsTemp].sort((a, b) => compareNumber(a.value, b.value)) | ||
| : undefined; |
Collaborator
There was a problem hiding this comment.
It seems this will sort options by value across all project types? Not sure if this is a good idea, as it means that "No" comes before "Yes" in many cases (as opposed to the current behaviour, where "Yes" usually comes before "No"). That seems a little counter-intuitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.