Skip to content

1. Fixed Tab bar circle not updating properly after showing or hiding… #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrPrakashR wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1. Fixed Tab bar circle not updating properly after showing or hiding… #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion WaveTab/Classes/Implementation/Wave Tab Bar Controller/WaveTabBarController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ open class WaveTabBarController: UITabBarController, WaveTabBarProtocol {
private var circle: UIView?
private var imageView: UIImageView?

private var tabSelectedTintColor : UIColor = UIColor.clear
private var safeSelectedIndex: Int {
return selectedIndex < tabBarItems.count ? selectedIndex : tabBarItems.count - 1
}
Expand All @@ -48,6 +49,7 @@ open class WaveTabBarController: UITabBarController, WaveTabBarProtocol {
presenter = WaveTabBarPresenterBase(view: self)
presenter.viewDidLoad()
}


open override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)
Expand Down Expand Up @@ -100,6 +102,11 @@ open class WaveTabBarController: UITabBarController, WaveTabBarProtocol {
}

func setupCircle(_ width: Float) {

if circle != nil { // To remove Duplicate Circles From Tabbar
circle?.removeFromSuperview()
}

circle = UIView(frame: CGRect(x: 0.0, y: 0.0, width: CGFloat(width), height: CGFloat(width)))
circle?.layer.cornerRadius = CGFloat(width) / 2
circle?.center = CGPoint(x: tabBarItems[safeSelectedIndex].center.x, y: 0.0)
Expand Down Expand Up @@ -145,10 +152,15 @@ open class WaveTabBarController: UITabBarController, WaveTabBarProtocol {
}

func setupImageView(_ center: Float) {

let image = viewControllers?[safeSelectedIndex].tabBarItem.selectedImage?.withRenderingMode(.alwaysTemplate)
if tabBar.tintColor != UIColor.clear { // To Prevent From setting Clear Color At Line 141
tabSelectedTintColor = tabBar.tintColor
}

imageView = UIImageView(image: image)
imageView?.contentMode = UIView.ContentMode.scaleAspectFit
imageView?.tintColor = tabBar.tintColor
imageView?.tintColor = tabSelectedTintColor
circle?.addSubview(imageView!)
imageView?.center = CGPoint(x: CGFloat(center), y: CGFloat(center))
}
Expand Down