Open
Conversation
Valiunia
approved these changes
Nov 24, 2025
Contributor
|
@zmofei Why did we bump or were we bumping manifest versions since 7.0 had not been released yet? |
There was a problem hiding this comment.
Pull request overview
This PR bumps the version to 0.7.1 and fixes logging reliability during server startup by ensuring the transport connection is established before sending any log messages.
Key changes:
- Enabled the
loggingcapability in the MCP server configuration - Deferred tracing initialization error logging until after server connection is established
- Moved server connection earlier in the startup sequence to ensure all logging messages are sent through a ready transport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request focuses on improving the initialization and logging process for tracing in the
src/index.tsserver startup sequence. The changes ensure that tracing initialization errors are captured and logged after the server connection is established, and add support for logging as a server capability.Key improvements include:
Tracing initialization and error handling:
Errorobject for better message formatting. [1] [2]Server capabilities and startup sequence:
loggingcapability to the server's advertised capabilities, making it clear that logging is supported.Testing
Checklist
Additional Notes