This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Decouple style change and transitions update#15086
Open
pozdnyakov wants to merge 1 commit intomasterfrom
Open
[core] Decouple style change and transitions update#15086pozdnyakov wants to merge 1 commit intomasterfrom
pozdnyakov wants to merge 1 commit intomasterfrom
Conversation
pozdnyakov
added
the
⚠️ DO NOT MERGE
Contributor
|
@pozdnyakov I think we talked about this - but this looks good. Anything else need to happen before merging? Tests? |
pozdnyakov
removed
the
⚠️ DO NOT MERGE
Contributor
Author
Maybe a test proving that infinite loop problem is solved, otherwise it just should not break the existing behavior 😄 |
pozdnyakov
added
bug
Core
Contributor
|
Turns out we do have a test that fails 😄 What would be a good thing to specifically test this PR? |
pozdnyakov
force-pushed
the
mikhail_decouple_map_change_and_transition_updates
branch
from
a53d381 to
d2242a5
Compare
Update transitions in a separate call chain in order to avoid infinite loop, in case map is modified from within the transitions update callback.
pozdnyakov
force-pushed
the
mikhail_decouple_map_change_and_transition_updates
branch
from
d2242a5 to
148cfe9
Compare
Contributor
|
@pozdnyakov 👋 hey, what's blocking this / what are next steps? Is it waiting for re-review from the iOS team? |
Contributor
|
@pozdnyakov is this PR still in flight? I still think it would be a good addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update transitions in a separate call chain in order to avoid
infinite loop, in case map is modified from within the
transitions update callback.