Skip to content

Conversation

@underoot
Copy link
Member

@underoot underoot commented Jan 19, 2026

We shouldn't rely on the external API (relative to the library itself) for testing. While I fixed the currently failing test in the main by stubbing, some other test cases rely on the API. Failing tests relying on quite unpredictable behaviour, such as an empty response for a random string, and so on. For now, I suggest fixing these tests by stubbing (or, for fuzzyMatch, by updating the query). Later, we can replace all API-related test cases with stubs.

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under main heading before merging

@underoot underoot marked this pull request as ready for review January 20, 2026 12:00
@underoot underoot requested a review from stepankuzmin January 20, 2026 12:00
@underoot underoot merged commit fff44f2 into main Jan 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants