Update/stub Geocoding v5 related tests #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't rely on the external API (relative to the library itself) for testing. While I fixed the currently failing test in the
mainby stubbing, some other test cases rely on the API. Failing tests relying on quite unpredictable behaviour, such as an empty response for a random string, and so on. For now, I suggest fixing these tests by stubbing (or, forfuzzyMatch, by updating the query). Later, we can replace all API-related test cases with stubs.npm run docsand commit changes to API.mdmainheading before merging