be2: improve number extraction#2609
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
Bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
seems reasonable. ideally we have some more tests to demonstrate how this does/nt affect parsing, but i dont think that can be addressed in this PR.
I don't think that the fix is going to be this simple. The modification above has exposed another bug in the expression tree building/pruning steps that I'm trying to track down now. |
|
stale |
2 participants
Prior the BinExport extractor was not emitting number features for complex operands, e.g. aarch64 instructions with logical shift operators.