Upgrade workflows and dependencies to .NET 9 #28
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the Orleans.Identity library by rewriting documentation for clarity, upgrading NuGet dependencies to their latest versions, and consolidating GitHub Actions workflows into a unified CI/CD pipeline.
- Rewrote README with clearer structure, code examples, and explanations of authentication/authorization flow
- Updated multiple ASP.NET Core and supporting packages from 9.0.7 to 9.0.10, and ManagedCode.Communication packages from 9.0.0 to 9.6.5
- Replaced three separate GitHub Actions workflows with consolidated CI and release workflows
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Complete documentation rewrite with improved structure, clearer code examples, and better explanation of package purposes |
| ManagedCode.Orleans.Identity.Tests/ManagedCode.Orleans.Identity.Tests.csproj | Updated test dependencies to latest versions (ASP.NET Core 9.0.10, Microsoft.NET.Test.Sdk 18.0.0, xunit.runner.visualstudio 3.1.5) |
| ManagedCode.Orleans.Identity.Server/ManagedCode.Orleans.Identity.Server.csproj | Updated ManagedCode.Communication packages and Microsoft.Extensions.DependencyInjection to 9.0.10 |
| ManagedCode.Orleans.Identity.Core/ManagedCode.Orleans.Identity.Core.csproj | Updated ManagedCode.Communication packages and Microsoft.Extensions.DependencyInjection to 9.0.10 |
| ManagedCode.Orleans.Identity.Client/ManagedCode.Orleans.Identity.Client.csproj | Updated ManagedCode.Communication packages and Microsoft.Extensions.DependencyInjection to 9.0.10 |
| Directory.Build.props | Updated DotNet.ReproducibleBuilds from 1.2.25 to 1.2.39 |
| .github/workflows/release.yml | New comprehensive release workflow with build, NuGet publishing, and GitHub release creation |
| .github/workflows/nuget.yml | Removed legacy NuGet workflow (replaced by release.yml) |
| .github/workflows/dotnet.yml | Removed legacy dotnet workflow (replaced by ci.yml and release.yml) |
| .github/workflows/codeql-analysis.yml | Modernized CodeQL workflow with updated actions versions and explicit build steps |
| .github/workflows/ci.yml | New consolidated CI workflow for pull requests with build, test, and code coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KSemenenko
deleted the
codex/install-dotnet9-and-update-github-actions
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Publish to NuGet | ||
| id: publish | ||
| continue-on-error: true | ||
| run: | | ||
| set +e | ||
| OUTPUT="" | ||
| PUBLISHED=false | ||
|
|
||
| for package in ./artifacts/*.nupkg; do | ||
| echo "Publishing $package..." | ||
| RESULT=$(dotnet nuget push "$package" \ | ||
| --api-key ${{ secrets.NUGET_API_KEY }} \ | ||
| --source https://api.nuget.org/v3/index.json \ | ||
| --skip-duplicate 2>&1) | ||
| EXIT_CODE=$? | ||
| echo "$RESULT" | ||
| OUTPUT="$OUTPUT$RESULT" | ||
|
|
||
| if [ $EXIT_CODE -eq 0 ]; then | ||
| echo "Successfully published $package" | ||
| PUBLISHED=true | ||
| elif echo "$RESULT" | grep -q "already exists"; then | ||
| echo "Package already exists, skipping..." | ||
| else | ||
| echo "Failed to publish $package" | ||
| exit 1 |
There was a problem hiding this comment.
The new release workflow wraps the NuGet push script in a step with continue-on-error: true. When dotnet nuget push fails for reasons other than an already-published package, the script exits with a non‑zero code, but continue-on-error causes the job to succeed anyway and only skip the later release job. This regresses from the previous workflow where publishing errors failed the run outright, so maintainers may miss broken releases (bad API key, network outages, etc.) because the workflow finishes successfully. Dropping continue-on-error would surface publishing failures properly.
Useful? React with 👍 / 👎.
|
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6907afd0425c83268d4dff39d3874ea5