Set lower default wheel zoom sensitivity for haplotype networks#934
Open
blankirigaya wants to merge 1 commit intomalariagen:masterfrom
Open
Set lower default wheel zoom sensitivity for haplotype networks#934blankirigaya wants to merge 1 commit intomalariagen:masterfrom
blankirigaya wants to merge 1 commit intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #504
Exposes wheel_sensitivity as a parameter on plot_haplotype_network(), defaulting to 0.1 (vs cytoscape.js's default of 1). This prevents accidentally zooming out when scrolling over a haplotype network, while still allowing users to tune the sensitivity to their preference.
Made possible by the wheelSensitivity prop added in dash-cytoscape v1.0.0 (plotly/dash-cytoscape#203), which is already our minimum required version.
Changes:
Add wheel_sensitivity: float = 0.1 parameter to plot_haplotype_network()