Skip to content

Comments

fix: define missing Anopheles cache-name properties#932

Open
Flamki wants to merge 1 commit intomalariagen:masterfrom
Flamki:GH900-fix-cache-name-properties
Open

fix: define missing Anopheles cache-name properties#932
Flamki wants to merge 1 commit intomalariagen:masterfrom
Flamki:GH900-fix-cache-name-properties

Conversation

@Flamki
Copy link

@Flamki Flamki commented Feb 23, 2026

What problem does this solve?

roh_hmm(), ihs_gwss(), and xpehh_gwss() can hit abstract cache-name properties that are not implemented in all Anopheles subclasses, leading to NotImplementedError during use.

How does it solve it?

  • Adds concrete cache-name constants/properties to all four subclasses:
    • Ag3: add _roh_hmm_cache_name
    • Af1: add _roh_hmm_cache_name
    • Amin1: add _xpehh_gwss_cache_name, _ihs_gwss_cache_name, _roh_hmm_cache_name
    • Adir1: add _xpehh_gwss_cache_name, _ihs_gwss_cache_name, _roh_hmm_cache_name
  • Adds regression test tests/test_anopheles_cache_names.py to enforce these subclass property definitions.

Relevant issue

Fixes #900

Testing done

  • pytest -q tests/test_anopheles_cache_names.py -vv
  • Result: 4 passed

Breaking changes / migration notes

  • None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NotImplementedError on roh_hmm(), ihs_gwss(), and xpehh_gwss() across all subclasses

1 participant