fix: strip whitespace from instance configuration values

[okxint]

Strip whitespace from config values before persisting. Closes #8737

Summary by CodeRabbit

• Bug Fixes
  • Configuration values are normalized before saving: missing values become empty strings, inputs are trimmed of surrounding whitespace, and non-null values are coerced to strings prior to storage/encryption—reducing inconsistent formatting and related issues.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8b3667e1-d42a-4dbd-b703-9965aa6c1ee8

📥 Commits

Reviewing files that changed from the base of the PR and between 83640d8 and 79b7306.

📒 Files selected for processing (1)

• apps/api/plane/license/api/views/configuration.py

---

📝 Walkthrough

Walkthrough

InstanceConfigurationEndpoint.patch now reads raw request values, coerces missing/None to an empty string, converts non-None values to stripped strings (removing leading/trailing whitespace) before applying encryption or saving them.

Changes

Cohort / File(s)	Summary
Configuration Value Normalization apps/api/plane/license/api/views/configuration.py	Changed InstanceConfigurationEndpoint.patch to read raw_value = request.data.get(...), normalize raw_value to "" when None or to str(raw_value).strip() otherwise, then use the normalized value for encrypted or plaintext assignment; bulk update and response remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble at the trailing space away,
Trim the crumbs so tokens play.
Configs lean and secrets clear,
OAuth hops without a fear. 🐇✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description is minimal but addresses the issue. However, it lacks required template sections like Type of Change, Test Scenarios, and detailed explanation.	Fill out the description template with Type of Change (Bug fix), Test Scenarios describing how the fix was validated, and a more detailed explanation of the changes made.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and concisely describes the main change: stripping whitespace from instance configuration values to fix OAuth issues.
Linked Issues check	✅ Passed	The code change in InstanceConfigurationEndpoint.patch() successfully implements the fix by stripping whitespace from configuration values before persisting them, directly addressing issue #8737.
Out of Scope Changes check	✅ Passed	The changes are limited to the specific fix for stripping whitespace in configuration values, with no unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/api/plane/license/api/views/configuration.py`:
- Line 48: When building the new config value, don't call str(...) on a JSON
null; instead read the raw = request.data.get(configuration.key,
configuration.value) and if raw is None set value to an empty string (or other
empty/unset sentinel) before calling .strip(); this prevents JSON null from
becoming the literal "None" in persisted config and aligns with
get_configuration_value() semantics. Ensure you update the assignment around
request.data.get(configuration.key, configuration.value) (referenced by
configuration.key and configuration.value) to handle raw is None explicitly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e07f9fde-d22f-4ff3-bd46-379d4b142a8e

📥 Commits

Reviewing files that changed from the base of the PR and between 6627282 and 91f8ea2.

📒 Files selected for processing (1)

• apps/api/plane/license/api/views/configuration.py

[okxint]

Hey, friendly follow-up on this — let me know if there's anything I should adjust. Happy to iterate on feedback!