fix: added bundler script for types + exported OAuthClient#24
fix: added bundler script for types + exported OAuthClient#24Prashant-Surya merged 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughVersion bumped to 0.2.6 with a new TypeScript declaration bundling build step integrated via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
17-17: Consider removing--no-checkflag and verify thetypesfield configuration.The
--no-checkflag skips type checking during bundle generation, which could hide type errors in the bundled declarations. Additionally, thetypesfield (line 11) still points todist/index.d.tsrather than the newly generateddist/types.bundle.d.ts.Clarify whether:
- The bundle file is intended to be the main types entry point (if so, update line 11 to
"types": "dist/types.bundle.d.ts")- The
--no-checkflag is necessary (consider removing it to catch type errors during build)♻️ Proposed refinement
If the bundle should be the main types entry:
- "types": "dist/index.d.ts", + "types": "dist/types.bundle.d.ts",And consider enabling type checking:
- "build:types-bundle": "dts-bundle-generator --no-check -o dist/types.bundle.d.ts dist/index.d.ts", + "build:types-bundle": "dts-bundle-generator -o dist/types.bundle.d.ts dist/index.d.ts",
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.jsonsrc/index.ts
🔇 Additional comments (4)
package.json (3)
3-3: LGTM!The version bump from 0.2.5 to 0.2.6 is appropriate for a patch release that adds new functionality and build tooling.
18-18: LGTM!The build script correctly chains TypeScript compilation followed by type bundling using
&&for sequential execution.
50-50: No action required—dts-bundle-generator version ^9.5.1 is current.Version 9.5.1 is the latest available on npm (released April 2024), and no known security vulnerabilities were detected.
src/index.ts (1)
4-6: OAuthClient module is properly implemented and correctly exported.The
src/client/oauth-client.tsfile exists with theOAuthClientclass properly defined and exported. The export statement insrc/index.tscorrectly references the module.
Description
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.