-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ansible-project-libvirt with AWX integration #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update repo references to ansible-project-libvirt - Rename AAP resources from libvirt-infra to libvirt - Use ghcr.io/makeitworkcloud/runner:latest container - Update ansible-lint to v25.12.1 - Add community.sops to requirements.yml - Remove deprecated jinja2_native from ansible.cfg - Exclude playbooks/ and vars/ from ansible-lint (vault-encrypted)
Alpine 3.21 has Python 3.12, not 3.13
API-based playbook cannot dry-run - dependent variables undefined when tasks skip
- Rewrite setup playbook using awx.awx.project, inventory, host, credential, job_template - Move to .setup_project.yml (hidden from AAP playbook discovery) - Restore --check --diff in CI workflow - Add awx.awx to requirements.yml - Use CONTROLLER_OPTIONAL_API_URLPATTERN_PREFIX for AAP compatibility
- Pre-commit job runs basic hooks (skips ansible-lint) - Ansible-check job installs collections, runs ansible-lint, runs --check --diff - Enable ansible-lint for playbooks/ directory - Add Makefile targets: lint, check, commit (all set ANSIBLE_VAULT_PASSWORD_FILE) - Add .envrc for direnv users
- Merge pre-commit and ansible-check into single job - Capture ansible-playbook --check --diff output - Truncate to 1000 lines for safety - Post as PR comment using github-script
- Project sync fails in check mode when project doesn't exist yet - Disable scm_update_on_launch since CI handles sync
- Add ANSIBLE_INVENTORY_UNPARSED_WARNING to suppress 'No inventory was parsed' warning - Use continue-on-error pattern in check workflow to capture output before failing - Add apply target to Makefile
- Remove AAP-specific CONTROLLER_OPTIONAL_API_URLPATTERN_PREFIX - Rename aap_* variables to awx_* - Update comments and play names
Ansible Check (dry-run) |
xnoto
added a commit
that referenced
this pull request
Dec 28, 2025
* feat: migrate from aap-libvirt-infra - Update repo references to ansible-project-libvirt - Rename AAP resources from libvirt-infra to libvirt - Use ghcr.io/makeitworkcloud/runner:latest container - Update ansible-lint to v25.12.1 - Add community.sops to requirements.yml - Remove deprecated jinja2_native from ansible.cfg - Exclude playbooks/ and vars/ from ansible-lint (vault-encrypted) * fix: use system python for ansible-lint pre-commit hook Alpine 3.21 has Python 3.12, not 3.13 * fix: remove ansible-playbook --check from CI API-based playbook cannot dry-run - dependent variables undefined when tasks skip * refactor: replace URI calls with awx.awx collection modules - Rewrite setup playbook using awx.awx.project, inventory, host, credential, job_template - Move to .setup_project.yml (hidden from AAP playbook discovery) - Restore --check --diff in CI workflow - Add awx.awx to requirements.yml - Use CONTROLLER_OPTIONAL_API_URLPATTERN_PREFIX for AAP compatibility * fix: split plays so secrets load before module_defaults evaluation * refactor: split CI into pre-commit and ansible-check jobs - Pre-commit job runs basic hooks (skips ansible-lint) - Ansible-check job installs collections, runs ansible-lint, runs --check --diff - Enable ansible-lint for playbooks/ directory - Add Makefile targets: lint, check, commit (all set ANSIBLE_VAULT_PASSWORD_FILE) - Add .envrc for direnv users * fix: run ansible-lint via pre-commit in CI for consistency * refactor: single CI job with PR comment for ansible check output - Merge pre-commit and ansible-check into single job - Capture ansible-playbook --check --diff output - Truncate to 1000 lines for safety - Post as PR comment using github-script * fix: skip project sync in check mode, disable scm_update_on_launch - Project sync fails in check mode when project doesn't exist yet - Disable scm_update_on_launch since CI handles sync * fix: suppress localhost inventory warning in CI and Makefile * refactor: update PR comments instead of creating new ones * fix: suppress inventory warnings and improve CI failure handling - Add ANSIBLE_INVENTORY_UNPARSED_WARNING to suppress 'No inventory was parsed' warning - Use continue-on-error pattern in check workflow to capture output before failing - Add apply target to Makefile * fix: embed HTML marker in comment body for find-comment to work * test: verify PR comment update * fix: skip prepare-comment step for non-PR events * refactor: delete and recreate PR comment for fresh timestamp * refactor: use johanwulf/replace-comment action * fix: use full version tag v1.0.0 for replace-comment * refactor: migrate from AAP to AWX - Remove AAP-specific CONTROLLER_OPTIONAL_API_URLPATTERN_PREFIX - Rename aap_* variables to awx_* - Update comments and play names * chore: align pre-commit config and fix trailing newlines * fix: downgrade pre-commit-hooks to v5.0.0 for Python 3.12 compat * fix: add setup-python for Python 3.13, restore pre-commit-hooks v6.0.0 * fix: install python3.13 via dnf in container * fix: use setup-python and pip install pre-commit * fix: use --break-system-packages for pip install * refactor: split lint and check jobs, use pre-commit/action * fix: exclude playbooks from ansible-lint (vault-encrypted vars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary