refactor: add smooth-cursor analytics via npm#861
Closed
Code-Parth wants to merge 13 commits intomagicuidesign:mainfrom
Closed
refactor: add smooth-cursor analytics via npm#861Code-Parth wants to merge 13 commits intomagicuidesign:mainfrom
Code-Parth wants to merge 13 commits intomagicuidesign:mainfrom
Conversation
Update/smooth cursor
Removed 'cdn.outrank.so' from allowed image domains.
|
@Code-Parth is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
There are too many commits, I suppose. Those aren’t all required, but this is because of an old PR #841 |
Member
|
Thank you so much for the contribution and for taking the time to improve this component. After reviewing it, we’re hesitant to merge this as-is. The main concern is introducing smooth-cursor as a runtime dependency in this repo. Because of that, we can’t move forward with this version right now. We really appreciate the effort here, and we’d be happy to review an alternative that keeps the implementation in-repo (without adding that external dependency). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.