Skip to content

Conversation

@MrBlackGhostt
Copy link
Contributor

@MrBlackGhostt MrBlackGhostt commented Jan 3, 2026

Summary

  • Fix config.example.toml remotes examples to include 3 remotes (devnet HTTP, devnet WebSocket, and Helius gRPC) to match magicblock-config coverage expectations.

Compatibility

  • No breaking changes
  • Config change (describe): example config/comment only (no runtime behavior change)
  • Migration needed

Testing

  • cargo test -p magicblock-config test_example_config_full_coverage

Checklist

  • docs updated
  • closes N/A

Summary by CodeRabbit

  • Chores
    • Updated default devnet endpoints to HTTPS/WSS/gRPC-style addresses for improved connectivity.
    • Added a clear note that gRPC remotes require a Helius API key/token and should be configured using your Helius gRPC endpoint.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 3, 2026

📝 Walkthrough

Walkthrough

The config.example.toml file’s remotes default was updated to ["https://api.devnet.solana.com", "wss://api.devnet.solana.com", "grpcs://laserstream-devnet-ewr.helius-rpc.com?api-key=YOUR_API_KEY"]. Preceding comments were added explaining that the gRPC remote requires an API key and showing the sample grpcs://... ?api-key=YOUR_API_KEY format.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46b632e and f1ef3d9.

📒 Files selected for processing (1)
  • config.example.toml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 746
File: magicblock-config/src/tests.rs:680-703
Timestamp: 2025-12-15T20:32:57.435Z
Learning: In the magicblock-validator repository, gRPC remotes do not support URL aliases (mainnet, devnet, local) like RPC and WebSocket remotes do. The resolve_url function passes gRPC URLs through as-is without alias resolution.
📚 Learning: 2025-12-15T20:32:57.435Z
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 746
File: magicblock-config/src/tests.rs:680-703
Timestamp: 2025-12-15T20:32:57.435Z
Learning: In the magicblock-validator repository, gRPC remotes do not support URL aliases (mainnet, devnet, local) like RPC and WebSocket remotes do. The resolve_url function passes gRPC URLs through as-is without alias resolution.

Applied to files:

  • config.example.toml
🔇 Additional comments (1)
config.example.toml (1)

58-61: LGTM! All previous issues successfully addressed.

The changes correctly implement the required three-remote configuration and resolve all concerns from previous reviews:

Formatting fixed: Proper spacing after commas in the array
Valid gRPC endpoint: Uses correct Helius format with network specifier, domain, and API key parameter
Clear documentation: Added helpful comments explaining API key requirement, URL format pattern, and documentation reference
Orphaned comment removed: Previous misleading comment has been cleaned up

The example configuration now provides clear guidance for users while using appropriate placeholders (YOUR_API_KEY) for an example file. The implementation matches the test expectations mentioned in the PR description.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9f100a and 81d312f.

📒 Files selected for processing (1)
  • config.example.toml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 746
File: magicblock-config/src/tests.rs:680-703
Timestamp: 2025-12-15T20:32:57.435Z
Learning: In the magicblock-validator repository, gRPC remotes do not support URL aliases (mainnet, devnet, local) like RPC and WebSocket remotes do. The resolve_url function passes gRPC URLs through as-is without alias resolution.

Put the space for better readability 
Put the grpc placeholder to put the endpoint there
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81d312f and 46b632e.

📒 Files selected for processing (1)
  • config.example.toml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-15T20:32:57.435Z
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 746
File: magicblock-config/src/tests.rs:680-703
Timestamp: 2025-12-15T20:32:57.435Z
Learning: In the magicblock-validator repository, gRPC remotes do not support URL aliases (mainnet, devnet, local) like RPC and WebSocket remotes do. The resolve_url function passes gRPC URLs through as-is without alias resolution.

Applied to files:

  • config.example.toml

Updated gRPC remote configuration and added example format.
Copy link
Collaborator

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@GabrielePicco GabrielePicco added this pull request to the merge queue Jan 4, 2026
Merged via the queue into magicblock-labs:master with commit a34fc15 Jan 4, 2026
6 of 7 checks passed
@MrBlackGhostt
Copy link
Contributor Author

I am understanding more about the magicblock and understand more to contribute more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants