-
Notifications
You must be signed in to change notification settings - Fork 28
docs(config): fix example remotes list #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(config): fix example remotes list #799
Conversation
📝 WalkthroughWalkthroughThe ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-12-15T20:32:57.435ZApplied to files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
config.example.toml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 746
File: magicblock-config/src/tests.rs:680-703
Timestamp: 2025-12-15T20:32:57.435Z
Learning: In the magicblock-validator repository, gRPC remotes do not support URL aliases (mainnet, devnet, local) like RPC and WebSocket remotes do. The resolve_url function passes gRPC URLs through as-is without alias resolution.
Put the space for better readability Put the grpc placeholder to put the endpoint there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
config.example.toml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-15T20:32:57.435Z
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 746
File: magicblock-config/src/tests.rs:680-703
Timestamp: 2025-12-15T20:32:57.435Z
Learning: In the magicblock-validator repository, gRPC remotes do not support URL aliases (mainnet, devnet, local) like RPC and WebSocket remotes do. The resolve_url function passes gRPC URLs through as-is without alias resolution.
Applied to files:
config.example.toml
Updated gRPC remote configuration and added example format.
GabrielePicco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
a34fc15
|
I am understanding more about the magicblock and understand more to contribute more |
Summary
config.example.tomlremotes examples to include 3 remotes (devnet HTTP, devnet WebSocket, and Helius gRPC) to matchmagicblock-configcoverage expectations.Compatibility
Testing
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.