Skip to content

Conversation

@GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Dec 18, 2025

Summary by CodeRabbit

  • Chores
    • Reorganized module structure: removed the instruction_builder module and made the discriminator module unconditionally available.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR modifies module declarations in src/lib.rs: the discriminator module is now included unconditionally (previously behind #[cfg(not(feature = "sdk"))]), and the pub mod instruction_builder is removed entirely.

Changes

Cohort / File(s) Summary
Module exports and feature-gating adjustments
src/lib.rs
Removed conditional compilation guard from discriminator module, making it always available; removed the entire pub mod instruction_builder declaration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify whether removing instruction_builder is intentional and won't cause downstream breakage
  • Confirm that unconditional inclusion of discriminator aligns with overall feature strategy
  • Check for any documentation or changelog entries related to these public API changes

Possibly related PRs

Suggested reviewers

  • snawaz
  • taco-paco
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch picco/add-builder-disc-to-sdk

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 735640a and a7d7ff6.

📒 Files selected for processing (1)
  • src/lib.rs (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GabrielePicco GabrielePicco merged commit d21761f into main Dec 18, 2025
1 of 2 checks passed
@GabrielePicco GabrielePicco deleted the picco/add-builder-disc-to-sdk branch December 18, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants