Open
Conversation
Fix a few frontend bugs
Provides methods to make it easier and less error-prone when adding or removing a downloaded episode, wether local or on the server
If it is going to fail just let it fail on the actual search request
This merge was a doozy
Fix horust memory leak
fix(helm): workaround bitnami image deprecation
feat(helm): support external databases that generate connection secrets
So more fields can be accessed. In the future the redundant args should be removed.
The rss feed doesn't link to itself, of course, so this needs to be done explicitly And it turns out I was right, there is an easier way to go from a json Value to a struct.
Episode page can take a url param `episode_id` that points to an episode in the db to pull metadata from. If this is not present, the method using other params (podcast_title, etc) are used instead. The logic for getting the metadata is mostly unchanged. The global AppState is used less, and Episode pages (with appropriate url params) can be visited directly through the url. Page state is managed in an enum that allows for Loading, Error, and Ok states. Some field name discrepencies in Episode are corrected with serde aliases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.