Made small improvements so the README is clearer#16
Open
talolard wants to merge 1 commit intomachinelearnjs:masterfrom
Open
Made small improvements so the README is clearer#16talolard wants to merge 1 commit intomachinelearnjs:masterfrom
talolard wants to merge 1 commit intomachinelearnjs:masterfrom
Conversation
I spent a few hours fighting with this after copy pasting from the README. I've adjusted two things that I missed at first and hope will be simpler for the next person 1) To load in the browser the wasm file needs to be served on the same path. This was stated but easy to miss so I made it bold. 2) If you don't specify probabilityEstimates: true then predictProbability returns noise. This wasn't obvious and I went down a rabbit hole till I figured it out. So I added a commented out line specifying so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a few hours fighting with this after copy pasting from the README.
I've adjusted two things that I missed at first and hope will be simpler for the next person