Skip to content

feat(rokt): Complete migration of Rokt kit into v3 monorepo#1267

Open
rmi22186 wants to merge 3 commits into
feat/web-sdk-owned-types-workstation-v3from
feat/migrate-rokt-kit-to-monorepo
Open

feat(rokt): Complete migration of Rokt kit into v3 monorepo#1267
rmi22186 wants to merge 3 commits into
feat/web-sdk-owned-types-workstation-v3from
feat/migrate-rokt-kit-to-monorepo

Conversation

@rmi22186
Copy link
Copy Markdown
Member

Summary

  • Migrate the individual Rokt kit into kits/rokt as the TypeScript/Vite/Vitest package used by the v3 monorepo.
  • Keep kits/rokt/src/Rokt-Kit.ts byte-for-byte identical to the individual Rokt kit source on refactor/use-core-sdk-types.
  • Add local core SDK public type exports and wire the Rokt kit build to consume local generated @mparticle/web-sdk / @mparticle/web-sdk/internal declarations before the
    coordinated v3 release exists on npm.

Source

  • Individual Rokt kit repo: ~/mParticle/apps/testapp/identity-examples/js/Integrations/mparticle-javascript-integration-rokt
  • Source branch for src/Rokt-Kit.ts: refactor/use-core-sdk-types

Verification

  • cmp confirms kits/rokt/src/Rokt-Kit.ts matches the individual Rokt kit source file.
  • npm run build in kits/rokt passes.
  • npm run lint in kits/rokt passes.
  • npm test in kits/rokt passes: 207 tests.
  • Root npm run lint passes.

Notes

  • Root npm run build:types still prints pre-existing declaration emit/type diagnostics, but the script already masks those with || true and emits the declaration files
    consumed by the Rokt kit build.

@rmi22186 rmi22186 changed the base branch from workstation/3.0-release-2 to feat/web-sdk-owned-types-workstation-v3 May 19, 2026 13:32
@rmi22186 rmi22186 force-pushed the feat/migrate-rokt-kit-to-monorepo branch from 508a124 to a8c187c Compare May 19, 2026 13:49
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
34.1% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@rmi22186 rmi22186 marked this pull request as ready for review May 29, 2026 19:32
@rmi22186 rmi22186 requested a review from a team as a code owner May 29, 2026 19:32
@cursor
Copy link
Copy Markdown

cursor Bot commented May 29, 2026

PR Summary

Medium Risk
Large third-party kit surface (identity sync, event/batch forwarding, launcher/session) is vendored into the monorepo; behavioral risk is low if Rokt-Kit.ts is truly unchanged, but build/type wiring and release paths are new integration points.

Overview
Adds kits/rokt as the v3 monorepo home for the Rokt integration (@mparticle/web-rokt-kit 1.26.1), packaging the standalone kit with Vite (IIFE/CJS/ESM + .d.ts), Vitest, and ESLint 9 flat config instead of only living in the old integration repo.

prebuild runs the repo root build:types so the kit can type-check against locally generated @mparticle/web-sdk / internal declarations before those packages ship on npm; runtime still depends on @mparticle/web-sdk. Rokt-Kit.ts is carried over unchanged from the standalone repo’s refactor/use-core-sdk-types branch (identity/event stream, workspace IDSync, reporting, Thank You element, etc.).

Repo hygiene for the new package includes .gitignore, Node 24 via .nvmrc, Prettier, an expanded CHANGELOG.md, release.config.js / scripts/release.sh (build + commit dist), and lint rules split for src/** vs test/**.

Reviewed by Cursor Bugbot for commit aa0da06. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant