Handle legacy persisted domain mappings safely

[ankitsingh08]

Background

• This issue appears to have been introduced after #588, where persisted DomainMapping parsing began expecting overridesSubdirectory to always be present.
• Users upgrading from older Android SDK versions can still have persisted UploadSettings / NetworkOptions JSON containing legacy domainMappings entries that do not include overridesSubdirectory.
• In mParticle logs, this surfaced as:
  • No value for overridesSubdirectory
  • Attempt to invoke virtual method 'com.mparticle.networking.DomainMapping com.mparticle.networking.DomainMapping$Builder.build()' on a null object reference
• The current parser expected overridesSubdirectory to always be present, which caused legacy entries to fail parsing.
• In the persisted NetworkOptions flow, that parse failure could produce a null DomainMapping.Builder, and the subsequent .build() call could trigger a null object reference crash.
• Because these values are read from persisted upload settings, affected users could continue seeing repeated failures until the stale rows were replaced.

What Has Changed

• Updated DomainMapping JSON parsing to use a backward-compatible default of false when overridesSubdirectory is missing.
• Hardened NetworkOptions parsing so invalid persisted domain mapping entries are skipped instead of crashing the entire parse flow.
• Added regression tests covering:
  • legacy persisted DomainMapping JSON without overridesSubdirectory
  • NetworkOptions JSON with one valid persisted mapping and one invalid mapping

Screenshots/Video

• Not applicable for this change.

Checklist

• I have performed a self-review of my own code.
• I have made corresponding changes to the documentation.
• I have added tests that prove my fix is effective or that my feature works.
• I have tested this locally.

Additional Notes

• Local validation run:
  • ./gradlew :android-core:testDebugUnitTest --tests com.mparticle.networking.NetworkOptionsTest
• The fix is intentionally minimal and additive to preserve backward compatibility and avoid API changes.

[cursor]

PR Summary

Medium Risk
Touches persisted NetworkOptions/DomainMapping JSON parsing used to route network traffic, so a bug could change endpoint selection or pinning behavior; changes are small and add safe defaults/guards to reduce crash risk.

Overview
Improves resilience when deserializing persisted NetworkOptions containing legacy or corrupted domainMappings.

DomainMapping now treats missing overridesSubdirectory as false via optBoolean, and NetworkOptions.withNetworkOptions skips (with a warning) any domain mapping entries that fail to parse instead of calling .build() on a null builder.

Adds unit tests covering legacy mappings without overridesSubdirectory and mixed valid/invalid persisted mappings.

^{Reviewed by Cursor Bugbot for commit a99c2dc. Bugbot is set up for automated code reviews on this repo. Configure here.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud