refactor: remove unused useEffect for theme application in StyleExamp…#3
Merged
refactor: remove unused useEffect for theme application in StyleExamp…#3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request removes an unused useEffect hook from the StyleExample component that was previously used for theme application. The effect is no longer needed since theme application is now handled automatically by App.tsx on startup, and this component only manages manual theme switching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
StyleExamplecomponent by removing an unuseduseEffecthook that contained a comment about theme application. This cleanup simplifies the code and reflects that theme handling is now managed elsewhere ([example/src/components/StyleExample.tsxL245-L249](https://github.com/mCodex/react-native-plugpag-nitro/pull/3/files#diff-5e6e7ae83ff89fb841fa8a3b60d200b4f1356c92c57310e085e3c47aa8652009L245-L249)).