Skip to content

Fix compilation error on non-S3 boards. #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovyan03 merged 1 commit into from
Apr 3, 2026
Merged

Fix compilation error on non-S3 boards. #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/utility/Power_Class.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ namespace m5
M5.In_I2C.writeRegister8(m5pm1_i2c_addr, 0x16, reg_val, i2c_freq);
// gpio1 mode: output: register 0x10 bit 1 (bit on = output mode)
// gpio2 mode: input: register 0x10 bit 2 (bit off = input mode)
// gpio3 mode: input: register 0x10 bit 3 (bit off = output mode)
// gpio3 mode: input: register 0x10 bit 3 (bit on = output mode)
reg_val = M5.In_I2C.readRegister8(m5pm1_i2c_addr, 0x10, i2c_freq);
reg_val |= (1 << 1); // Set bit 1 , set to output mode
reg_val &= ~(1 << 2); // Clear bit 2 , set to input mode
Expand Down Expand Up @@ -1632,13 +1632,15 @@ namespace m5
case pmic_t::pmic_axp2101:
Axp2101.setChargeCurrent(max_mA);
break;


#if defined (CONFIG_IDF_TARGET_ESP32S3)
case pmic_t::pmic_m5pm1:
if (max_mA >= 650)
M5.In_I2C.bitOff(m5pm1_i2c_addr, 0x11, 1 << 3, i2c_freq); // Set G3 to low level
else
M5.In_I2C.bitOn(m5pm1_i2c_addr, 0x11, 1 << 3, i2c_freq); // Set G3 to High level
break;
#endif

#endif

Expand Down