Skip to content

fix from_pretrained in_channels, etc.#94

Open
s-rog wants to merge 8 commits into
lukemelas:masterfrom
s-rog:master
Open

fix from_pretrained in_channels, etc.#94
s-rog wants to merge 8 commits into
lukemelas:masterfrom
s-rog:master

Conversation

@s-rog

@s-rog s-rog commented Oct 18, 2019

Copy link
Copy Markdown

fix from_pretrained param in_channels
rename existing from_name to _from_name
added new from_name to match from_pretrained signature

s-rog added 3 commits October 18, 2019 11:10
added options to override dropout and drop_connect
add mish to utils
added mish as option in set_swish
@s-rog

s-rog commented Oct 18, 2019

Copy link
Copy Markdown
Author

maybe should have pushed these to another fork... but these commits add dropout and drop_connect options as well as mish (as an option in set_swish)

s-rog added 2 commits October 18, 2019 18:41
fixed typo in set_swish
fixed typo in Mish
@s-rog

s-rog commented Oct 19, 2019

Copy link
Copy Markdown
Author

perhaps it's simpler to have just a from_name function and a pretrained boolean arg?

consolidated from_name and from_pretrained
@ahmadmughees

Copy link
Copy Markdown

any update to this? facing the same issue

@s-rog

s-rog commented Dec 9, 2019

Copy link
Copy Markdown
Author

you can use my fork for now

@ahmadmughees

Copy link
Copy Markdown

you can use my fork for now

thanks alot. already done that. its working great,

@s-rog

s-rog commented Dec 10, 2019

Copy link
Copy Markdown
Author

Good to hear! let me know if you think any of the changes I made are unintuitive since I did a little more than just fixing the channels issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants