fix stuck poll() when interface down#987
Open
msaare123 wants to merge 1 commit into
Open
Conversation
In linux when any of the polled interfaces is brought down (NETDEV_GOING_DOWN) rings were previosly set to NM_KR_LOCKED state. That caused nm_kr_tryget() to get stuck in retry loop inside poll() until interface was eventually brought up again. In this patch the issue was fixed by setting ring state to NM_KR_STOPPED instead of NM_KR_LOCKED. After the fix poll() will return POLLERR for interface that is brought down which in my mind is the correct operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In linux when any of the polled interfaces is brought down (NETDEV_GOING_DOWN) rings were previously set to NM_KR_LOCKED state. That caused nm_kr_tryget() to get stuck in retry loop inside poll() until interface was eventually brought up again.
In this patch the issue was fixed by setting ring state to NM_KR_STOPPED instead of NM_KR_LOCKED. After the fix poll() will return POLLERR for interface that is brought down which in my mind is the correct operation.