add support for maven asset delivery #83
Open
+83
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincarter
reviewed
Jun 7, 2024
Member
There was a problem hiding this comment.
ADD is usually preferred because it's natively supported by Docker and I think has layer caching benefits. Another reason is that historically some Debian images didn't include curl and so this wouldn't have worked. I'll need to do some testing because my instinct is to continue using ADD.
Member
There was a problem hiding this comment.
This feels like a large amount of work to get the Maven URL to download the JAR. Is there any way we can determine the URL without making HTTP requests?
I understand wanting to stop using the cdn.lucee.org bucket if that's extra machinery on the build side to ensure that the file is uploaded. Just wondering if there's an easier way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get jars from maven instead of lucee.org (later is deprecated and will no longer get updates when Lucee 5 LTS period ends).
For them moment i kept a fallback to the old solution in case of an issue, that can be removed in the future.
"light" is not on Maven yet, but i will add it.
"ADD" in dockerfile caused some cache issue, so i switched to "curl".