Ajustes teste unitarios by engFelipeMonteiro · Pull Request #66 · lucasmonstrox/PyTibia

engFelipeMonteiro · 2023-05-31T18:33:27Z

Ajustes teste unitarios
Funcáo pra salvar resultado de teste unitario

- Ajustes macos - Funcáo pra salvar resultado de teste unitario

engFelipeMonteiro · 2023-05-31T18:35:17Z

Aguardar validação

engFelipeMonteiro · 2023-05-31T19:32:10Z

todos os testes unitarios passando

lucasmonstrox · 2023-05-31T19:50:56Z

.gitignore

+env39
+tests/validation_images/*.png


Por curiosidade, o que gerou esses folders?

env39/
pasta do venv que criei dentro da pasta.

Fiz um metodo pra criar imagens desenhando um quadrado na parte selecinada baseado na posição recebida pelos metodos, pra validação visual dos metodos
tests/validation_images/*.png

lucasmonstrox · 2023-05-31T19:51:09Z

src/repositories/gameWindow/core.py

@@ -1,13 +1,19 @@
-from typing import Tuple, Union
+from typing import Tuple, Union, Dict


Eu sugeria eu ordenar os imports para ficar mais organizado:

Suggested change

from typing import Tuple, Union, Dict

from typing import Dict, Tuple, Union

lucasmonstrox · 2023-05-31T19:53:15Z

src/utils/camera.py

+
+import pyautogui
+import cv2
+import numpy as np
+
+class PyCamera():
+    is_capturing = True
+
+    def get_latest_frame(self, path='screen.png'):
+        img = pyautogui.screenshot()
+        img = cv2.cvtColor(np.array(img), cv2.COLOR_RGB2GRAY)
+        if path:
+            # import cv2; cv2.imwrite('screen_test.png', screenshot)
+            cv2.imwrite(path, img)
+        return img
+


Seria legal criar uma classe com Polimorfismo para decidir qual SO usar e qual lib usar.

o DxCam serve para o windows, dxlib serve para linux, tb deve ser para mac, que tal tentar? Performance interessa muito nesse projeto.

lucasmonstrox · 2023-05-31T19:54:26Z

tests/unit/repositories/actionBar/extractors/test_getCooldownsImage.py

@@ -1,3 +1,4 @@
+


Pode remover essa linha em branco?

pode, desculpa

lucasmonstrox · 2023-05-31T19:56:17Z

src/repositories/gameWindow/core.py

+def get_global_game_cache_window_cache() -> Dict:
+    """
+    function to ease mocking the cache
+    """
+    global gameWindowCache
+    return gameWindowCache


Pode explicar o que aconteceu aqui? Evita o snake, estou usando o lowerUpperCase getGlobalGameCacheWindow

flake8 usa o snake case, criei o metodo pra facilitar o mock, o mock anterior não funcionava

lucasmonstrox · 2023-05-31T19:59:53Z

...ries/battleList/locators/getContainerBottomBarPosition/test_getContainerBottomBarPosition.py

    screenshotImage = loadFromRGBToGray(f'{currentPath}/screenshot.png')
    containerBottomBarPos = getContainerBottomBarPosition(screenshotImage)
-    expectedContainerBottomBarPos = (1748, 621, 156, 4)
+    # save for conference


Remove o comentário

lucasmonstrox · 2023-05-31T20:00:40Z

tests/unit/repositories/gameWindow/test_arrows.py

+import pathlib
+import cv2
+import numpy as np
+import pytest
+
+from src.repositories.gameWindow.core import getLeftArrowPosition, getRightArrowPosition
+
+from tests.utils import result_pos_draw


Suggested change

import pathlib

import cv2

import numpy as np

import pytest

from src.repositories.gameWindow.core import getLeftArrowPosition, getRightArrowPosition

from tests.utils import result_pos_draw

import cv2

import numpy as np

import pathlib

import pytest

from src.repositories.gameWindow.core import getLeftArrowPosition, getRightArrowPosition

from tests.utils import result_pos_draw

lucasmonstrox · 2023-05-31T20:00:58Z

tests/unit/repositories/gameWindow/test_arrows.py

+@pytest.mark.parametrize("img, is_gray", [
+    (img01, False),
+    (img02_gray, True),
+    (img03, False),
+    (img04, False),
+])


Qual a idéia aqui?

usar diversas imagens como input do teste unitario, sendo alguns 1920X1080 e outras resolução mac os(16:10)

lucasmonstrox · 2023-05-31T20:01:02Z

tests/unit/repositories/gameWindow/test_arrows.py

+@pytest.mark.parametrize("img, is_gray", [
+    (img01, False),
+    (img02_gray, True),
+    (img03, False),
+])


Qual a idéia aqui?

lucasmonstrox · 2023-05-31T20:01:15Z

tests/validation_images/.keep

Não versiona isso

sonarqubecloud · 2023-06-08T07:13:19Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
17 Code Smells

No Coverage information
0.0% Duplication

- Ajustes teste unitarios

135162d

- Ajustes macos - Funcáo pra salvar resultado de teste unitario

ajuste teste unitario

46ef5ae

lucasmonstrox requested changes May 31, 2023

View reviewed changes

		env39
		tests/validation_images/*.png No newline at end of file

		@@ -1,13 +1,19 @@
		from typing import Tuple, Union
		from typing import Tuple, Union, Dict

	from typing import Tuple, Union, Dict
	from typing import Dict, Tuple, Union

Conversation

engFelipeMonteiro commented May 31, 2023

Uh oh!

engFelipeMonteiro commented May 31, 2023

Uh oh!

engFelipeMonteiro commented May 31, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants