fix: replace bare except clauses with except Exception in ga.py#490
Open
Kailigithub wants to merge 1 commit into
Open
fix: replace bare except clauses with except Exception in ga.py#490Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
Replace all 8 bare `except:` clauses in ga.py with `except Exception:`. Bare except catches SystemExit and KeyboardInterrupt which can mask critical failures and make debugging harder. Affected locations: - code_run output printing (lines 48-49) - file access stats loading (line 159) - timeout argument parsing (line 289) - web_execute_js file save error (line 348) - web_execute_js result printing (line 351) - plan completion check (line 433) - verbose prompt printing (line 544)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all 8 bare
except:clauses inga.pywithexcept Exception:.Why
Bare
except:catches everything includingSystemExitandKeyboardInterrupt, which can:Changes
All 8 bare
except:→except Exception:inga.py:Testing
python3 -m py_compile ga.py— passesExceptioncovers the same error types these handlers were meant to catch