fix: replace remaining bare except clauses with except Exception#481
Open
Kailigithub wants to merge 1 commit into
Open
fix: replace remaining bare except clauses with except Exception#481Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
Fix E722 violations in four frontend files not covered by PR lsdefine#463: - frontends/stapp.py: stdout/stderr reconfigure fallback - frontends/stapp2.py: stdout/stderr reconfigure fallback - frontends/tgapp.py: telegram import fallback - frontends/wechatapp.py: send_typing loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:clauses withexcept Exception:in four frontend files that were not covered by PR #463 (fix/issue-463-bare-except-clauses).Changes
except:→except Exception:(stdout/stderr reconfigure fallback)except:→except Exception:(stdout/stderr reconfigure fallback)except:→except Exception:(telegram import fallback)except:→except Exception:(send_typing loop)Motivation
Bare
except:catches all exceptions includingKeyboardInterruptandSystemExit, which can mask serious bugs and prevent clean shutdown. Usingexcept Exception:allows system-exiting exceptions to propagate normally.All changes pass
python3 -m py_compilesyntax validation.