[opentitantool,rules,signing] Enhance ownership verification and add signature test rule#29757
Open
anthonychen1251 wants to merge 2 commits intolowRISC:earlgrey_1.0.0from
Open
Conversation
The ownership verify command previously only supported the `EcdsaP256` algorithm with embedded signatures. This commit enhances the verification process to support SPX and Hybrid algorithms. Since SPX algorithms utilize detached signatures, new CLI arguments (`--ecdsa-sig`, `--spx-sig`) were added to the `OwnershipVerifyCommand` to allow users to provide them manually. Signed-off-by: Anthony Chen <antchen@google.com>
This introduces a new Bazel rule, `ownership_signature_test`, designed to verifies ownership blocks against both embedded keys and explicitly provided ECDSA and SPX public keys and detached signatures. To support this rule, a new bash template, `ownership_signature_test.template.sh`, was added to orchestrate the verification commands. Additionally, this commit adds generation rules in `sw/device/silicon_creator/lib/ownership/testdata/BUILD` to create test ownership blocks (e.g., hybrid_owner.bin) and their corresponding signatures using opentitantool. Signed-off-by: Anthony Chen <antchen@google.com>
anthonychen1251
force-pushed
the
support-spx-ownership-verify
branch
from
bc2e3df to
ea5be49
Compare
Member
Author
|
The failed test |
cfrantz
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new Bazel test rule for ownership signature verification and enhances opentitantool to support SPX and Hybrid signature verification for owner block.
ownership verifycommand is updated to support SPX and Hybrid algorithms. Previously, only EcdsaP256 with embedded signatures was supported.ownership_signature_testrule: A new Bazel rule and corresponding bash template that orchestrates the verification of ownership blocks against ECDSA and SPX public keys.