[sram_ctrl,dv] Tweak sram_ctrl_readback_err_vseq#29738
Merged
rswarbrick merged 1 commit intolowRISC:masterfrom Apr 17, 2026
Merged
[sram_ctrl,dv] Tweak sram_ctrl_readback_err_vseq#29738rswarbrick merged 1 commit intolowRISC:masterfrom
rswarbrick merged 1 commit intolowRISC:masterfrom
Conversation
rswarbrick
force-pushed
the
sram-ctrl-readback
branch
from
960052c to
97d1903
Compare
rswarbrick
force-pushed
the
sram-ctrl-readback
branch
from
97d1903 to
43dc4c0
Compare
rswarbrick
requested review from
marnovandermaas
and removed request for
a team
rswarbrick
force-pushed
the
sram-ctrl-readback
branch
from
43dc4c0 to
14c69ea
Compare
nasahlpa
approved these changes
Apr 17, 2026
Contributor
nasahlpa
left a comment
nasahlpa
left a comment
There was a problem hiding this comment.
Thanks @rswarbrick, this now looks much cleaner than before. As far as I can see, the test does what it is supposed to do, so LGTM!
rswarbrick
force-pushed
the
sram-ctrl-readback
branch
from
14c69ea to
e8f4496
Compare
KinzaQamar
reviewed
Apr 17, 2026
| // A tuple that describes an FI path. | ||
| typedef struct { | ||
| // The HDL path | ||
| string path; |
Contributor
There was a problem hiding this comment.
Did you intend to align with L19?
Contributor
Author
There was a problem hiding this comment.
Yes, and I think it probably makes sense, making the structure slightly easier to read. Does that seem reasonable to you?
KinzaQamar
reviewed
Apr 17, 2026
| } fi_desc_s; | ||
|
|
||
| // If true, the generated memory operations will be writes. If false, they will be reads. | ||
| rand bit m_target_write; |
Contributor
There was a problem hiding this comment.
Could you remove extra space
Contributor
Author
There was a problem hiding this comment.
Yes, definitely. I was going to say "ah, but it's aligned with the guy below". True, but m_targeted_desc (below) isn't aligned. Let's drop the extras.
|
|
||
| // A mask that gives the bits that should be flipped to inject a fault | ||
| uvm_hdl_data_t mask; | ||
| } fi_desc_s; |
Contributor
There was a problem hiding this comment.
I'd like it even more if verible was shouting to declare it as fi_desc_t_s but linters are not that smart.
This was originally motivated by trying to get the test to pass when
run under Xcelium as well as VCS, but there was some room for tidying
up the test.
Changes in this commit:
- There are LOTS of comments that explain what is going on.
- Sequence variables are now randomised in a slightly simpler
manner (as rand class variables). The only hard bit was picking an
unpacked config struct. The trick is to pick the index in the
randomisation and then copy the value at that index in
post_randomize.
- We now allow a few extra TL reads after injecting the error. This
wasn't done in the past. The scoreboard was fixed in the previous
commit to allow such stimulus.
- A check for integrity errors in cip_base_scoreboard needs
disabling.
Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
sram-ctrl-readback
branch
from
e8f4496 to
2c3ffd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally motivated by trying to get the test to pass when
run under Xcelium as well as VCS, but there was some room for tidying
up the test.
Changes in this commit:
There are LOTS of comments that explain what is going on.
Sequence variables are now randomised in a slightly simpler
manner (as rand class variables). The only hard bit was picking an
unpacked config struct. The trick is to pick the index in the
randomisation and then copy the value at that index in
post_randomize.
We now allow a few extra TL reads after injecting the error. This
wasn't done in the past. The scoreboard was fixed in the previous
commit to allow such stimulus.
A check for integrity errors in cip_base_scoreboard needs
disabling.