Conversation
ziuziakowska
force-pushed
the
verilator-dram
branch
2 times, most recently
from
1b61868 to
67fb035
Compare
engdoreis
left a comment
engdoreis
left a comment
There was a problem hiding this comment.
LGTM, but I think that Marno is the best to review this.
Can you please add a verilator DRAM smoketest to make sure this will not break in follow up PRs.
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
It would be good to have a test in CI for making sure that this works. Is that something you can add before we merge this PR?
|
I was also thinking if we can map things using the -E command then maybe we shouldn't create the patch for the -r -m commands at all. This minimises the amount of patches we need to maintain. |
ziuziakowska
force-pushed
the
verilator-dram
branch
2 times, most recently
from
5d00653 to
34aabd0
Compare
Yeah I was unsure about that one. Multiple |
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
ziuziakowska
force-pushed
the
verilator-dram
branch
from
34aabd0 to
2fe8b16
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
This is great, is there a way we can test this change before merging? Preferably in CI. That's the only thing stopping me from approving this PR right now.
ziuziakowska
force-pushed
the
verilator-dram
branch
7 times, most recently
from
804884d to
b0b2e41
Compare
There was a problem hiding this comment.
I'm sorry for not being clear when I asked for a test. I had in mind a test similar in structure to this one. The one you implemented in this PR is not wrong, but since it is basically the bootroom in the near feature, so it won't add extra coverage.
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
This is needed for building executables to run in DRAM which starts at 2 GiB, the `medlow` code model can only address the first and last 2 GiB in RV64 so DRAM is just out of its range. Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
ziuziakowska
force-pushed
the
verilator-dram
branch
from
b0b2e41 to
883609a
Compare
3 participants
Adds the DRAM as a memory area that can be loaded on the command line, so that we can skip the bootloader in Verilator in the future.
The memory can be loaded into using multiple
-Eflags to load binaries into the corresponding memory areas,or using the-rand-mflags to explicitly load into ROM/SRAM or DRAM.We currently don't use this functionality as we still need a Verilator bypass in the boot ROM before we can run all tests from DRAM on all environments.Added a test now, needed quite a bit of machinery to get it going (needed the ability to load multiple ELF's with the test runner, compile and link for DRAM which we do not do yet) but that should be cleaned up once we can load all our tests into DRAM in addition to just SRAM.
Closes #377.