util: FPGA runner: rework to use asyncio#366
Open
ziuziakowska wants to merge 2 commits intolowRISC:mainfrom
Open
util: FPGA runner: rework to use asyncio#366ziuziakowska wants to merge 2 commits intolowRISC:mainfrom
ziuziakowska wants to merge 2 commits intolowRISC:mainfrom
Conversation
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
ziuziakowska
changed the title
engdoreis
reviewed
Mar 31, 2026
| p = await asyncio.create_subprocess_exec(*command) | ||
| if await p.wait() != 0: | ||
| sys.exit(1) | ||
| p = await asyncio.create_subprocess_exec(*command) |
Collaborator
There was a problem hiding this comment.
Please keep the workaround comment.
Collaborator
There was a problem hiding this comment.
Nit. Changing the order of the functions in the same commit made it harder to review. It would be good to separate into different commits in the next PRs.
| return 0 | ||
| p = await asyncio.create_subprocess_exec(*command) | ||
| if await p.wait() != 0: | ||
| sys.exit(1) |
Collaborator
There was a problem hiding this comment.
If the load fails we would not know why? I suggest keeping the log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from: #299
This reworks the FPGA runner to use asyncio to read from the UART while the flash is being written. This was causing some problems for me locally when adding some more debugging output, as in the time between finishing flashing and opening the UART file descriptor, the receive buffer would be overflowed and the test status would be dropped.