Tidy up the last few Ruff problems in deploy.py#157
Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Open
Tidy up the last few Ruff problems in deploy.py#157rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Conversation
rswarbrick
force-pushed
the
deploy-minor-ruff
branch
from
a322c14 to
41d5667
Compare
Contributor
Author
|
Note: The import line at the top of the file actually also appears in #154, but that's the only merge conflict - the PRs can land in either order. |
Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
deploy-minor-ruff
branch
from
41d5667 to
f31b308
Compare
AlexJones0
approved these changes
Apr 2, 2026
| weight = 10 | ||
|
|
||
| def __init__(self, run_items, sim_cfg) -> None: | ||
| def __init__(self, run_items: list[RunTest], sim_cfg: FlowCfg) -> None: |
Contributor
There was a problem hiding this comment.
Nit: ideally this would be
Suggested change
| def __init__(self, run_items: list[RunTest], sim_cfg: FlowCfg) -> None: | |
| def __init__(self, run_items: Iterable[RunTest], sim_cfg: FlowCfg) -> None: |
and then later down we would do:
- self.dependencies += run_items
+ self.dependencies.extend(run_items)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.