Correct the type for RunMode.build_mode#152
Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Open
Correct the type for RunMode.build_mode#152rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Conversation
This is a bit of an ugly dance, but checks the type properly at run-time and also convinces Pyright about the existence and type of RunMode.build_mode. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
AlexJones0
approved these changes
Apr 2, 2026
Contributor
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
As a disclaimer, I haven't looked at DVSim's modes at all before. But from a pure Python perspective this change LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of an ugly dance, but checks the type properly at run-time and also convinces Pyright about the existence and type of RunMode.build_mode.