Open
Conversation
This is set from Deploy.get_timeout_mins, which returns a float (probably the right type for this: "time out after 2.5 minutes" seems like a reasonable thing to say). Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
timeout-mins-type
branch
from
fe721a4 to
d01d4df
Compare
AlexJones0
reviewed
Apr 2, 2026
Contributor
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
Thanks for the change. I've felt it's strange to have the timeout specified in minutes as a base unit rather than seconds, but maybe it makes more sense in the case of timeouts for longer running DV tests and that's how it has always been defined in the HJSONs?
| def timeout_secs(self) -> int | None: | ||
| """Returns the timeout applied to the launched job, in seconds.""" | ||
| return None if self.timeout_mins is None else self.timeout_mins * 60 | ||
| return None if self.timeout_mins is None else math.floor(self.timeout_mins * 60) |
Contributor
There was a problem hiding this comment.
This timeout_secs is just used by timeout and sleep interfaces inside the launchers - no reason not to make it return a float as well instead of math.flooring the output.
AlexJones0
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is set from Deploy.get_timeout_mins, which returns a float (probably the right type for this: "time out after 2.5 minutes" seems like a reasonable thing to say).