Move the "name" field up to FlowCfg#145
Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Open
Conversation
Looking through hjson files quickly, I'm pretty certain that they always provide a name (which gets installed at runtime through _merge_hjson). Tell the type system about this. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
name-flow-cfg
branch
from
e24fdd0 to
2030f15
Compare
AlexJones0
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking through hjson files quickly, I'm pretty certain that they always provide a name (which gets installed at runtime through _merge_hjson). Tell the type system about this.